They can be smelly if not cared for properly. Turtles are messy eaters and the tank needs to be spot cleaned daily, removing waste and uneaten food. Waste and leftover food left for a while are the contributors to odors. Also remove some of the water in the turtle's tank every week. If you like, you can use a separate tank for feeding to keep odors away.
